-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[DNS] Internal DNS follow-up adjustments #20594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNS] Internal DNS follow-up adjustments #20594
Conversation
|
Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. |
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryUpdated internal DNS documentation with improved clarity and structure.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add What is Hyperlint?Hyperlint is an AI agent that helps you write, edit, and maintain your documentation. Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation. |
daisyfaithauma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add conditional rendering for create internal zone * Clear out unused components from internal-zone-create * Fix syntax to make conditional property opitional * Add .yaml file so that iDNS comes up in /products * Update DNS records link to point to #internal-dns-records * Create and apply partial for reference-zone-intro * Add info about CNAME flatenning to iDNS docs * Add note about wildcard record and reference zones * Revert "Add .yaml file so that iDNS comes up in /products" This reverts commit 5dff074. * Remove CNAME flattening desc to be added on a separate PR
* Add conditional rendering for create internal zone * Clear out unused components from internal-zone-create * Fix syntax to make conditional property opitional * Add .yaml file so that iDNS comes up in /products * Update DNS records link to point to #internal-dns-records * Create and apply partial for reference-zone-intro * Add info about CNAME flatenning to iDNS docs * Add note about wildcard record and reference zones * Revert "Add .yaml file so that iDNS comes up in /products" This reverts commit 5dff074. * Remove CNAME flattening desc to be added on a separate PR
Summary
PCX-16198