Skip to content

Conversation

@RebeccaTamachiro
Copy link
Contributor

Summary

PCX-16198

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner March 6, 2025 17:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.

@github-actions github-actions bot added size/s product:dns Issues or PRs related to DNS labels Mar 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@hyperlint-ai
Copy link
Contributor

hyperlint-ai bot commented Mar 13, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Updated internal DNS documentation with improved clarity and structure.

  • Modified the internal DNS setup instructions for better clarity.
  • Added a new section for referencing zones in internal DNS queries.
  • Created partials for internal zone creation and reference zone introduction.

Modified Files

  • src/content/docs/dns/internal-dns/get-started.mdx
  • src/content/docs/dns/internal-dns/index.mdx
  • src/content/docs/dns/internal-dns/internal-zones/index.mdx
  • src/content/docs/dns/internal-dns/internal-zones/reference-zones.mdx
  • src/content/docs/dns/internal-dns/internal-zones/setup.mdx

Added Files

  • src/content/partials/dns/internal-zone-create.mdx
  • src/content/partials/dns/reference-zone-intro.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

Copy link
Contributor

@daisyfaithauma daisyfaithauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RebeccaTamachiro RebeccaTamachiro merged commit bc72a40 into production Mar 14, 2025
11 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/internal-dns-v1-follow-up branch March 14, 2025 16:41
elithrar pushed a commit that referenced this pull request Mar 14, 2025
* Add conditional rendering for create internal zone

* Clear out unused components from internal-zone-create

* Fix syntax to make conditional property opitional

* Add .yaml file so that iDNS comes up in /products

* Update DNS records link to point to #internal-dns-records

* Create and apply partial for reference-zone-intro

* Add info about CNAME flatenning to iDNS docs

* Add note about wildcard record and reference zones

* Revert "Add .yaml file so that iDNS comes up in /products"

This reverts commit 5dff074.

* Remove CNAME flattening desc to be added on a separate PR
RebeccaTamachiro added a commit that referenced this pull request Apr 21, 2025
* Add conditional rendering for create internal zone

* Clear out unused components from internal-zone-create

* Fix syntax to make conditional property opitional

* Add .yaml file so that iDNS comes up in /products

* Update DNS records link to point to #internal-dns-records

* Create and apply partial for reference-zone-intro

* Add info about CNAME flatenning to iDNS docs

* Add note about wildcard record and reference zones

* Revert "Add .yaml file so that iDNS comes up in /products"

This reverts commit 5dff074.

* Remove CNAME flattening desc to be added on a separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:dns Issues or PRs related to DNS size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants